From fe7f44d51f85d7e8289e4d6cf37ecf3dffd46bad Mon Sep 17 00:00:00 2001
From: jgavalda <oriol.gavalda@concordia.ca>
Date: Wed, 12 Apr 2023 13:52:55 -0400
Subject: [PATCH] Fully functional Domestic Hot Water. Pending validation of
 results

---
 hub/exports/building_energy/idf.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/hub/exports/building_energy/idf.py b/hub/exports/building_energy/idf.py
index bf369ce0..51e8286d 100644
--- a/hub/exports/building_energy/idf.py
+++ b/hub/exports/building_energy/idf.py
@@ -254,7 +254,7 @@ class Idf:
     _schedule.type = schedule_type
     _schedule.data_type = cte.ANY_NUMBER
     _schedule.time_step = cte.HOUR
-    _schedule.time_range = cte.YEAR
+    _schedule.time_range = cte.DAY
     _schedule.day_types = ['monday',
                            'tuesday',
                            'wednesday',
@@ -265,7 +265,7 @@ class Idf:
                            'holiday',
                            'winter_design_day',
                            'summer_design_day']
-    _schedule.values = [value for _ in range(0, 8760)]
+    _schedule.values = [value for _ in range(0, 24)]
     return self._add_standard_compact_hourly_schedule(thermal_zone.usage_name, schedule_type, [_schedule])
 
   def _add_construction(self, thermal_boundary):
@@ -429,13 +429,13 @@ class Idf:
     method = 'Watts/Area'
     factor_size = thermal_zone.total_floor_area / thermal_zone.footprint_area
     peak_flow_rate = thermal_zone.domestic_hot_water.peak_flow*factor_size
-    _object = self._idf.newidfobject(self._DHW)
-    print(vars(_object))
+    #_object = self._idf.newidfobject(self._DHW)
+    #print(vars(_object))
     self._idf.newidfobject(self._DHW,
                            Name=f'{zone_name}_DHW',
                            Peak_Flow_Rate=peak_flow_rate,
-                           Flow_Rate_Fraction_Schedule_Name=f'DHW_prof {thermal_zone.usage_name}',
-                           Target_Temperature_Schedule_Name=f'DHW_temp {thermal_zone.usage_name}',
+                           Flow_Rate_Fraction_Schedule_Name=f'DHW_prof schedules {thermal_zone.usage_name}',
+                           Target_Temperature_Schedule_Name=f'DHW_temp schedules {thermal_zone.usage_name}',
                            EndUse_Subcategory=f'DHW {thermal_zone.usage_name}'
                            )
   def _rename_building(self, city_name):
@@ -489,7 +489,7 @@ class Idf:
             self._add_schedules(usage, 'DHW_prof', thermal_zone.domestic_hot_water.schedules)
             # self._add_service_temp_schedules(thermal_zone)
             value = int(thermal_zone.domestic_hot_water.service_temperature)
-            self._add_constant_hourly_year_schedules(thermal_zone, value, cte.DOMESTIC_HOT_WATER)
+            self._add_constant_hourly_year_schedules(thermal_zone, value, 'DHW_temp')
             self._add_people_activity_level_schedules(thermal_zone)
             self._add_zone(thermal_zone, building.name)
             self._add_heating_system(thermal_zone, building.name)