From 56fae48277ea052b80475d9943bf2f641c842319 Mon Sep 17 00:00:00 2001
From: jgavalda <oriol.gavalda@concordia.ca>
Date: Wed, 7 Jun 2023 16:17:46 -0400
Subject: [PATCH 1/2] Changed systems xml file to include new systems without
 cooling

---
 .../montreal_custom_systems.xml               | 58 +++++++++++++------
 1 file changed, 40 insertions(+), 18 deletions(-)

diff --git a/hub/data/energy_systems/montreal_custom_systems.xml b/hub/data/energy_systems/montreal_custom_systems.xml
index cdf914a5..d3a7591d 100644
--- a/hub/data/energy_systems/montreal_custom_systems.xml
+++ b/hub/data/energy_systems/montreal_custom_systems.xml
@@ -41,44 +41,44 @@
         <equipment id="1" type="Water distribution heating">
             <name>Water distribution heating</name>
             <distribution_heat_losses units="%">10</distribution_heat_losses>
-            <distribution_consumption_fix_flow units="%">4</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">1</distribution_consumption_variable_flow>
+            <distribution_consumption_fix_flow units="%">2</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">0</distribution_consumption_variable_flow>
         </equipment>
         <equipment id="2" type="Water distribution cooling">
             <name>Water distribution cooling</name>
-            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_heat_losses units="%">5</distribution_heat_losses>
             <distribution_consumption_fix_flow units="%">4</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">1</distribution_consumption_variable_flow>
+            <distribution_consumption_variable_flow units="%">0</distribution_consumption_variable_flow>
         </equipment>
         <equipment id="3" type="Central air distribution heating">
             <name>Central air distribution heating</name>
             <distribution_heat_losses units="%">10</distribution_heat_losses>
-            <distribution_consumption_fix_flow units="%">13</distribution_consumption_fix_flow>
+            <distribution_consumption_fix_flow units="%">0</distribution_consumption_fix_flow>
             <distribution_consumption_variable_flow units="%">13</distribution_consumption_variable_flow>
         </equipment>
         <equipment id="4" type="Central air distribution cooling">
             <name>Central air distribution cooling</name>
-            <distribution_heat_losses units="%">10</distribution_heat_losses>
-            <distribution_consumption_fix_flow units="%">13</distribution_consumption_fix_flow>
+            <distribution_heat_losses units="%">5</distribution_heat_losses>
+            <distribution_consumption_fix_flow units="%">0</distribution_consumption_fix_flow>
             <distribution_consumption_variable_flow units="%">13</distribution_consumption_variable_flow>
         </equipment>
         <equipment id="5" type="Local air distribution heating">
             <name>Local air distribution heating</name>
-            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_heat_losses units="%">5</distribution_heat_losses>
             <distribution_consumption_fix_flow units="%">8</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">8</distribution_consumption_variable_flow>
+            <distribution_consumption_variable_flow units="%">0</distribution_consumption_variable_flow>
         </equipment>
          <equipment id="6" type="Local air distribution cooling">
             <name>Local air distribution cooling</name>
-            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_heat_losses units="%">2</distribution_heat_losses>
             <distribution_consumption_fix_flow units="%">8</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">8</distribution_consumption_variable_flow>
+            <distribution_consumption_variable_flow units="%">0</distribution_consumption_variable_flow>
         </equipment>
         <equipment id="7" type="Refrigerant distribution">
             <name>Refrigerant distribution</name>
             <distribution_heat_losses units="%">1</distribution_heat_losses>
             <distribution_consumption_fix_flow units="%">1</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">2</distribution_consumption_variable_flow>
+            <distribution_consumption_variable_flow units="%">0</distribution_consumption_variable_flow>
         </equipment>
         <equipment id="8" type="No distribution">
             <name>No distribution</name>
@@ -94,7 +94,7 @@
         </equipment>
         <equipment id="2" type="fan-coils">
             <name>fan-coils</name>
-            <parasitic_consumption units="%">2</parasitic_consumption>
+            <parasitic_consumption units="%">1</parasitic_consumption>
         </equipment>
         <equipment id="3" type="inductors">
             <name>inductors</name>
@@ -122,7 +122,7 @@
             </demands>
             <equipments>
                 <generation_id>2</generation_id>
-                <distribution_id>1</distribution_id>
+                <distribution_id>8</distribution_id>
                 <dissipation_id>1</dissipation_id>
             </equipments>
         </system>
@@ -194,7 +194,7 @@
             </demands>
             <equipments>
                 <generation_id>2</generation_id>
-                <distribution_id>5</distribution_id>
+                <distribution_id>8</distribution_id>
                 <dissipation_id>3</dissipation_id>
             </equipments>
         </system>
@@ -218,7 +218,7 @@
         </demands>
         <equipments>
             <generation_id>2</generation_id>
-            <distribution_id>1</distribution_id>
+            <distribution_id>8</distribution_id>
             <dissipation_id>3</dissipation_id>
         </equipments>
         </system>
@@ -296,7 +296,7 @@
             </demands>
             <equipments>
                 <generation_id>7</generation_id>
-                <distribution_id>1</distribution_id>
+                <distribution_id>3</distribution_id>
                 <dissipation_id>2</dissipation_id>
             </equipments>
         </system>
@@ -307,7 +307,7 @@
             </demands>
             <equipments>
                 <generation_id>7</generation_id>
-                <distribution_id>2</distribution_id>
+                <distribution_id>4</distribution_id>
                 <dissipation_id>2</dissipation_id>
             </equipments>
         </system>
@@ -435,5 +435,27 @@
                 <system_id>15</system_id>
             </systems>
         </system_cluster>
+        <system_cluster name="system 8 gas">
+            <systems>
+                <system_id>1</system_id>
+            </systems>
+        </system_cluster>
+        <system_cluster name="system 8 gas pv">
+            <systems>
+                <system_id>1</system_id>
+                <system_id>15</system_id>
+            </systems>
+        </system_cluster>
+        <system_cluster name="system 8 electricity">
+            <systems>
+                <system_id>16</system_id>
+            </systems>
+        </system_cluster>
+        <system_cluster name="system 8 electricity pv">
+            <systems>
+                <system_id>16</system_id>
+                <system_id>15</system_id>
+            </systems>
+        </system_cluster>
     </system_clusters>
 </catalog>
-- 
2.39.5


From 4e382f0633bee722a8c232d335f32c2017ba2071 Mon Sep 17 00:00:00 2001
From: p_monsalvete <pilar.monsalvete@concordia.ca>
Date: Thu, 8 Jun 2023 09:58:57 -0400
Subject: [PATCH 2/2] updated systems catalog test

---
 tests/test_systems_catalog.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test_systems_catalog.py b/tests/test_systems_catalog.py
index 25562b4a..48af728c 100644
--- a/tests/test_systems_catalog.py
+++ b/tests/test_systems_catalog.py
@@ -15,7 +15,7 @@ class TestSystemsCatalog(TestCase):
     catalog = EnergySystemsCatalogFactory('montreal_custom').catalog
     catalog_categories = catalog.names()
     archetypes = catalog.names('archetypes')
-    self.assertEqual(19, len(archetypes['archetypes']))
+    self.assertEqual(23, len(archetypes['archetypes']))
     systems = catalog.names('systems')
     self.assertEqual(18, len(systems['systems']))
     generation_equipments = catalog.names('generation_equipments')
-- 
2.39.5