From 0e01971b4af4723ddefb788f80607aeb225e3a0e Mon Sep 17 00:00:00 2001
From: Ed Chalstrey <edwardchalstrey@gmail.com>
Date: Tue, 29 Mar 2022 14:46:18 +0100
Subject: [PATCH] add echos to extraction step

---
 etl/extract_mastermap.sh | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/etl/extract_mastermap.sh b/etl/extract_mastermap.sh
index f0863e0c..568c990d 100755
--- a/etl/extract_mastermap.sh
+++ b/etl/extract_mastermap.sh
@@ -1,31 +1,28 @@
 #!/usr/bin/env bash
 
-#
-# Extract MasterMap
-#
-
 : ${1?"Usage: $0 ./path/to/mastermap/dir"}
 
 data_dir=$1
 
-#
-# Extract buildings from *.gz to CSV
-#
+
+echo "Extract buildings from *.gz..."
+
 # Features where::
 #     descriptiveGroup = '(1:Building)'
 #
 # Use `fid` as source ID, aka TOID.
-#
 
 find $data_dir -type f -name '*.gz' -printf "%f\n" | \
 parallel \
 gunzip $data_dir/{} -k -S gml
 
+echo "Rename extracted files to .gml..."
 rename 's/$/.gml/' $data_dir/*[^gzvt]
 
 # Note: previously the rename cmd above resulted in some temp files being renamed to .gml
 # so I have specified the start of the filename (appears to be consistent for all OS MasterMap downloads)
 # we may need to update this below for other downloads
+echo "Covert .gml files to .csv"
 find $data_dir -type f -name '*5690395*.gml' -printf "%f\n" | \
 parallel \
 ogr2ogr \
@@ -35,5 +32,6 @@ ogr2ogr \
     TopographicArea \
     -lco GEOMETRY=AS_WKT
 
+echo "Remove .gfs and .gml files from previous steps..."
 rm $data_dir/*.gfs
 rm $data_dir/*.gml