a_adli/colouring-montreal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Correct API error on unknown field edit

Browse Source
This commit is contained in:
Maciej Ziarkowski 2021-09-24 20:32:05 +03:00
parent 8c8a6a8094
commit 522eff2031
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/api/services/domainLogic/validateUpdate.ts
View File

@ -12,6 +12,10 @@ addFormats(ajv);
const compiledSchemas = _.mapValues(fieldSchemaConfig, (val) => ajv.compile(val)); const compiledSchemas = _.mapValues(fieldSchemaConfig, (val) => ajv.compile(val));
function isDefined(key: string) {
return allAttributesConfig[key] !== undefined;
}
function canEdit(key: string, allowDerived: boolean = false) { function canEdit(key: string, allowDerived: boolean = false) {
const config = allAttributesConfig[key]; const config = allAttributesConfig[key];
@ -19,6 +23,10 @@ function canEdit(key: string, allowDerived: boolean = false) {
} }
export function validateFieldChange(field: string, value: any, isExternal: boolean = true) { export function validateFieldChange(field: string, value: any, isExternal: boolean = true) {
if(!isDefined(field)) {
throw new InvalidFieldError('Field does not exist', field);
}
const allowDerived = !isExternal; const allowDerived = !isExternal;
if(!canEdit(field, allowDerived)) { if(!canEdit(field, allowDerived)) {
throw new InvalidFieldError('Field is not editable', field); throw new InvalidFieldError('Field is not editable', field);