From 566b738f91302f0a22ecf6716b08776a5c6e6679 Mon Sep 17 00:00:00 2001
From: Tom Russell <tomalrussell@gmail.com>
Date: Wed, 14 Aug 2019 14:10:52 +0100
Subject: [PATCH] Fix building edit details on props change

- EditForm owns form state
- fully uncontrolled component
- when props change (e.g. when clicking on another building) the
  component should completely re-render
---
 app/src/frontend/building/building-edit.tsx | 1 +
 app/src/frontend/building/building-view.tsx | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/app/src/frontend/building/building-edit.tsx b/app/src/frontend/building/building-edit.tsx
index e29c09cd..b669d3e0 100644
--- a/app/src/frontend/building/building-edit.tsx
+++ b/app/src/frontend/building/building-edit.tsx
@@ -32,6 +32,7 @@ const BuildingEdit = (props) => {
     return (
         <Sidebar>
             <EditForm
+                key={props.building_id}  // provide key so that React re-creates if props change
                 {...section}
                 {...props}
                 cat={cat}
diff --git a/app/src/frontend/building/building-view.tsx b/app/src/frontend/building/building-view.tsx
index 424eaa94..672e9482 100644
--- a/app/src/frontend/building/building-view.tsx
+++ b/app/src/frontend/building/building-view.tsx
@@ -29,9 +29,7 @@ const BuildingView = (props) => {
     return (
         <Sidebar>
             <DataSection
-                key={section.slug}
                 cat={cat}
-                building_id={props.building_id}
                 {...section}
                 {...props}
             />