a_adli/colouring-montreal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix label click on like checkbox with non-uniq id

Browse Source 
The label for the like checkbox was not clickable because the ID #like
was not unique on the website. The ID has been changed to like_check
to avoid that.
This commit is contained in:
Maciej Ziarkowski 2019-10-16 13:30:59 +01:00
parent f189ae603e
commit 9d4d24aefc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/frontend/building/data-components/like-data-entry.tsx
View File

@ -29,12 +29,12 @@ const LikeDataEntry: React.FunctionComponent<any> = (props) => { // TODO: remove
} }
</p> </p>
<input className="form-check-input" type="checkbox" <input className="form-check-input" type="checkbox"
id="like" name="like" id="like_check" name="like"
checked={!!props.building_like} checked={!!props.building_like}
disabled={props.mode === 'view'} disabled={props.mode === 'view'}
onChange={props.onLike} onChange={props.onLike}
/> />
<label htmlFor="like" className="form-check-label"> <label htmlFor="like_check" className="form-check-label">
I like this building and think it contributes to the city! I like this building and think it contributes to the city!
</label> </label>
</Fragment> </Fragment>