From b46f637911321561efe950e4ab1c35768ce81342 Mon Sep 17 00:00:00 2001
From: Ed Chalstrey <edwardchalstrey@gmail.com>
Date: Thu, 12 May 2022 16:30:55 +0100
Subject: [PATCH] set up current_landuse_source like date_source

---
 .../frontend/building/data-containers/use.tsx | 189 +++++++++++-------
 app/src/frontend/config/data-fields-config.ts |   9 +
 2 files changed, 129 insertions(+), 69 deletions(-)

diff --git a/app/src/frontend/building/data-containers/use.tsx b/app/src/frontend/building/data-containers/use.tsx
index 04090357..8535767c 100644
--- a/app/src/frontend/building/data-containers/use.tsx
+++ b/app/src/frontend/building/data-containers/use.tsx
@@ -14,77 +14,128 @@ import Verification from '../data-components/verification';
 /**
  * Use view/edit section
  */
-const UseView: React.FunctionComponent<CategoryViewProps> = (props) => (
-    <Fragment>
-        <InfoBox msg="93% of properties in UK are dwellings so we have set this as the default colour. Can you help us colour-in all non-residential and mixed use buildings, and verify residential buildings too?"></InfoBox>
-        <MultiDataEntry
-            title={dataFields.current_landuse_group.title}
-            slug="current_landuse_group"
-            value={props.building.current_landuse_group}
-            mode={props.mode}
-            copy={props.copy}
-            onChange={props.onChange}
-            confirmOnEnter={true}
-            tooltip={dataFields.current_landuse_group.tooltip}
-            placeholder="Type new land use group here"
-            copyable={true}
-            autofill={true}
-            showAllOptionsOnEmpty={true}
-        />
-        <Verification
-            slug="current_landuse_group"
-            allow_verify={props.user !== undefined && props.building.current_landuse_group !== null && !props.edited}
-            onVerify={props.onVerify}
-            user_verified={props.user_verified.hasOwnProperty("current_landuse_group")}
-            user_verified_as={props.user_verified.current_landuse_group && props.user_verified.current_landuse_group.join(", ")}
-            verified_count={props.building.verified.current_landuse_group}
+const UseView: React.FunctionComponent<CategoryViewProps> = (props) => {
+    if (props.building.current_landuse_source == "Expert/personal knowledge of building" ||
+        props.building.current_landuse_source == "Online streetview image" ||
+        props.building.current_landuse_source == null
+       ){
+      return (
+          <Fragment>
+              <InfoBox msg="93% of properties in UK are dwellings so we have set this as the default colour. Can you help us colour-in all non-residential and mixed use buildings, and verify residential buildings too?"></InfoBox>
+              <MultiDataEntry
+                  title={dataFields.current_landuse_group.title}
+                  slug="current_landuse_group"
+                  value={props.building.current_landuse_group}
+                  mode={props.mode}
+                  copy={props.copy}
+                  onChange={props.onChange}
+                  confirmOnEnter={true}
+                  tooltip={dataFields.current_landuse_group.tooltip}
+                  placeholder="Type new land use group here"
+                  copyable={true}
+                  autofill={true}
+                  showAllOptionsOnEmpty={true}
+              />
+              <Verification
+                  slug="current_landuse_group"
+                  allow_verify={props.user !== undefined && props.building.current_landuse_group !== null && !props.edited}
+                  onVerify={props.onVerify}
+                  user_verified={props.user_verified.hasOwnProperty("current_landuse_group")}
+                  user_verified_as={props.user_verified.current_landuse_group && props.user_verified.current_landuse_group.join(", ")}
+                  verified_count={props.building.verified.current_landuse_group}
+                  />
+              {
+                  props.mode != 'view' &&
+                  <InfoBox msg="Land use order, shown below, is automatically derived from the land use groups"></InfoBox>
+              }
+              <DataEntry
+                  title={dataFields.current_landuse_order.title}
+                  tooltip={dataFields.current_landuse_order.tooltip}
+                  slug="current_landuse_order"
+                  value={props.building.current_landuse_order}
+                  mode={props.mode}
+                  disabled={true}
+                  copy={props.copy}
+                  onChange={props.onChange}
+              />
+              <SelectDataEntry
+                  title={dataFields.current_landuse_source.title}
+                  slug="current_landuse_source"
+                  value={props.building.current_landuse_source}
+                  mode={props.mode}
+                  copy={props.copy}
+                  onChange={props.onChange}
+                  tooltip={dataFields.current_landuse_source.tooltip}
+                  placeholder=""
+                  options={dataFields.current_landuse_source.items}
+                  />
+          </Fragment>
+        );
+      };
+    return (
+        <Fragment>
+            <InfoBox msg="93% of properties in UK are dwellings so we have set this as the default colour. Can you help us colour-in all non-residential and mixed use buildings, and verify residential buildings too?"></InfoBox>
+            <MultiDataEntry
+                title={dataFields.current_landuse_group.title}
+                slug="current_landuse_group"
+                value={props.building.current_landuse_group}
+                mode={props.mode}
+                copy={props.copy}
+                onChange={props.onChange}
+                confirmOnEnter={true}
+                tooltip={dataFields.current_landuse_group.tooltip}
+                placeholder="Type new land use group here"
+                copyable={true}
+                autofill={true}
+                showAllOptionsOnEmpty={true}
             />
-        {
-            props.mode != 'view' &&
-            <InfoBox msg="Land use order, shown below, is automatically derived from the land use groups"></InfoBox>
-        }
-        <DataEntry
-            title={dataFields.current_landuse_order.title}
-            tooltip={dataFields.current_landuse_order.tooltip}
-            slug="current_landuse_order"
-            value={props.building.current_landuse_order}
-            mode={props.mode}
-            disabled={true}
-            copy={props.copy}
-            onChange={props.onChange}
-        />
-        <SelectDataEntry
-            title={dataFields.current_landuse_source.title}
-            slug="current_landuse_source"
-            value={props.building.current_landuse_source}
-            mode={props.mode}
-            copy={props.copy}
-            onChange={props.onChange}
-            tooltip={dataFields.current_landuse_source.tooltip}
-            placeholder=""
-            options={[
-                "Expert/personal knowledge of building",
-                "Online streetview image",
-                "Open planning authority dataset",
-                "Open property tax dataset",
-                "Open housing dataset",
-                "Open address dataset",
-                "Other"
-            ]}
+            <Verification
+                slug="current_landuse_group"
+                allow_verify={props.user !== undefined && props.building.current_landuse_group !== null && !props.edited}
+                onVerify={props.onVerify}
+                user_verified={props.user_verified.hasOwnProperty("current_landuse_group")}
+                user_verified_as={props.user_verified.current_landuse_group && props.user_verified.current_landuse_group.join(", ")}
+                verified_count={props.building.verified.current_landuse_group}
+                />
+            {
+                props.mode != 'view' &&
+                <InfoBox msg="Land use order, shown below, is automatically derived from the land use groups"></InfoBox>
+            }
+            <DataEntry
+                title={dataFields.current_landuse_order.title}
+                tooltip={dataFields.current_landuse_order.tooltip}
+                slug="current_landuse_order"
+                value={props.building.current_landuse_order}
+                mode={props.mode}
+                disabled={true}
+                copy={props.copy}
+                onChange={props.onChange}
             />
-        <MultiDataEntry
-            title={dataFields.current_landuse_link.title}
-            slug="current_landuse_link"
-            value={props.building.current_landuse_link}
-            mode={props.mode}
-            copy={props.copy}
-            onChange={props.onChange}
-            tooltip={dataFields.current_landuse_link.tooltip}
-            placeholder="https://..."
-            editableEntries={true}
-            />
-    </Fragment>
-);
+            <SelectDataEntry
+                title={dataFields.current_landuse_source.title}
+                slug="current_landuse_source"
+                value={props.building.current_landuse_source}
+                mode={props.mode}
+                copy={props.copy}
+                onChange={props.onChange}
+                tooltip={dataFields.current_landuse_source.tooltip}
+                placeholder=""
+                options={dataFields.current_landuse_source.items}
+                />
+            <MultiDataEntry
+                title={dataFields.current_landuse_link.title}
+                slug="current_landuse_link"
+                value={props.building.current_landuse_link}
+                mode={props.mode}
+                copy={props.copy}
+                onChange={props.onChange}
+                tooltip={dataFields.current_landuse_link.tooltip}
+                placeholder="https://..."
+                editableEntries={true}
+                />
+        </Fragment>
+      );
+};
 const UseContainer = withCopyEdit(UseView);
 
 export default UseContainer;
diff --git a/app/src/frontend/config/data-fields-config.ts b/app/src/frontend/config/data-fields-config.ts
index 83c9cc79..a77998c1 100644
--- a/app/src/frontend/config/data-fields-config.ts
+++ b/app/src/frontend/config/data-fields-config.ts
@@ -198,6 +198,15 @@ export const dataFields = { /* eslint-disable @typescript-eslint/camelcase */
         title: "Source of information",
         tooltip: "Source for the current land use",
         example: "",
+        items: [
+            "Expert/personal knowledge of building",
+            "Online streetview image",
+            "Open planning authority dataset",
+            "Open property tax dataset",
+            "Open housing dataset",
+            "Open address dataset",
+            "Other"
+        ],
     },
     current_landuse_source_detail: {
         category: Category.LandUse,