a_adli/colouring-montreal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Parse building ID in API controller

Browse Source
This commit is contained in:
Maciej Ziarkowski 2020-01-02 12:39:24 +01:00
parent 82a50d77d6
commit f351c87756
1 changed files with 27 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
app/src/api/controllers/buildingController.ts
View File

@ -34,9 +34,10 @@ const getBuildingsByReference = asyncController(async (req: express.Request, res
// GET individual building, POST building updates // GET individual building, POST building updates
const getBuildingById = asyncController(async (req: express.Request, res: express.Response) => { const getBuildingById = asyncController(async (req: express.Request, res: express.Response) => {
const { building_id } = req.params; const buildingId = parseBuildingId(req.params.building_id);
try { try {
const result = await buildingService.getBuildingById(building_id); const result = await buildingService.getBuildingById(buildingId);
res.send(result); res.send(result);
} catch(error) { } catch(error) {
console.error(error); console.error(error);
@ -61,11 +62,12 @@ const updateBuildingById = asyncController(async (req: express.Request, res: exp
}); });
async function updateBuilding(req: express.Request, res: express.Response, userId: string) { async function updateBuilding(req: express.Request, res: express.Response, userId: string) {
const { building_id } = req.params; const buildingId = parseBuildingId(req.params.building_id);
const buildingUpdate = req.body; const buildingUpdate = req.body;
try { try {
const building = await buildingService.saveBuilding(building_id, buildingUpdate, userId); const building = await buildingService.saveBuilding(buildingId, buildingUpdate, userId);
if (typeof (building) === 'undefined') { if (typeof (building) === 'undefined') {
return res.send({ error: 'Database error' }); return res.send({ error: 'Database error' });
@ -81,9 +83,10 @@ async function updateBuilding(req: express.Request, res: express.Response, userI
// GET building UPRNs // GET building UPRNs
const getBuildingUPRNsById = asyncController(async (req: express.Request, res: express.Response) => { const getBuildingUPRNsById = asyncController(async (req: express.Request, res: express.Response) => {
const { building_id } = req.params; const buildingId = parseBuildingId(req.params.building_id);
try { try {
const result = await buildingService.getBuildingUPRNsById(building_id); const result = await buildingService.getBuildingUPRNsById(buildingId);
if (typeof (result) === 'undefined') { if (typeof (result) === 'undefined') {
return res.send({ error: 'Database error' }); return res.send({ error: 'Database error' });
@ -100,9 +103,11 @@ const getBuildingLikeById = asyncController(async (req: express.Request, res: ex
if (!req.session.user_id) { if (!req.session.user_id) {
return res.send({ like: false }); // not logged in, so cannot have liked return res.send({ like: false }); // not logged in, so cannot have liked
} }
const { building_id } = req.params;
const buildingId = parseBuildingId(req.params.building_id);
try { try {
const like = await buildingService.getBuildingLikeById(building_id, req.session.user_id); const like = await buildingService.getBuildingLikeById(buildingId, req.session.user_id);
// any value returned means like // any value returned means like
res.send({ like: like }); res.send({ like: like });
@ -112,9 +117,10 @@ const getBuildingLikeById = asyncController(async (req: express.Request, res: ex
}); });
const getBuildingEditHistoryById = asyncController(async (req: express.Request, res: express.Response) => { const getBuildingEditHistoryById = asyncController(async (req: express.Request, res: express.Response) => {
const { building_id } = req.params; const buildingId = parseBuildingId(req.params.building_id);
try { try {
const editHistory = await buildingService.getBuildingEditHistory(building_id); const editHistory = await buildingService.getBuildingEditHistory(buildingId);
res.send({ history: editHistory }); res.send({ history: editHistory });
} catch(error) { } catch(error) {
@ -127,13 +133,13 @@ const updateBuildingLikeById = asyncController(async (req: express.Request, res:
return res.send({ error: 'Must be logged in' }); return res.send({ error: 'Must be logged in' });
} }
const { building_id } = req.params; const buildingId = parseBuildingId(req.params.building_id);
const { like } = req.body; const { like } = req.body;
try { try {
const building = like ? const building = like ?
await buildingService.likeBuilding(building_id, req.session.user_id) : await buildingService.likeBuilding(buildingId, req.session.user_id) :
await buildingService.unlikeBuilding(building_id, req.session.user_id); await buildingService.unlikeBuilding(buildingId, req.session.user_id);
if (building.error) { if (building.error) {
return res.send(building); return res.send(building);
@ -156,6 +162,14 @@ const getLatestRevisionId = asyncController(async (req: express.Request, res: ex
} }
}); });
function parseBuildingId(building_id: string) {
const result = parseInt(building_id, 10);
if(isNaN(result)) {
throw new Error('Invalid building ID format');
}
return result;
}
export default { export default {
getBuildingsByLocation, getBuildingsByLocation,
getBuildingsByReference, getBuildingsByReference,