From f4a85e7a68a4fa23cfd7ab16dc2d2e64f0d95afd Mon Sep 17 00:00:00 2001 From: Ed Chalstrey Date: Fri, 8 Apr 2022 15:15:39 +0100 Subject: [PATCH] comment --- etl/update_building_records.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/etl/update_building_records.sh b/etl/update_building_records.sh index 874e08b1..fac45fd4 100644 --- a/etl/update_building_records.sh +++ b/etl/update_building_records.sh @@ -1,5 +1,10 @@ #!/usr/bin/env bash +## Comments: +## Is dynamics_has_demolished_buildings = TRUE sufficient to prevent buildings being loaded? - No +## Lets mark them, then see if there even are any +## Describe these changes in PR and ask for comment if the bool is sufficient + ## Prerequisites: ## - Make geometries table have coordinates (load_coordinates.sh) - DONE ## - = release_geometries @@ -18,7 +23,4 @@ # secondarily, if building.coordinates <10m away from any new_geometry.coordinates # older_building.dynamics_has_demolished_buildings = TRUE - # link new_geometry TOID in the geometries table to old building and delete duplicate building we just created for new_geometry - - -# Worry about build dates for switching next \ No newline at end of file + # link new_geometry TOID in the geometries table to old building and delete duplicate building we just created for new_geometry \ No newline at end of file