m_osman/city_retrofit
1
0
Fork 0
forked from s_ranjbar/city_retrofit
Code Pull Requests Activity

Merge branch 'homogeneize_todos' into 'master'

Browse Source 
Homogenize todos

See merge request Guille/hub!30
This commit is contained in:
Guillermo Gutierrez Morote 2022-11-09 16:44:34 +00:00
commit 779c3116a5
6 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
PYGUIDE.md
View File

@ -167,9 +167,9 @@ Attributes with known units should be explicit in method's comment.
#### To do's. #### To do's.
Pending to implement operations should be indicated with ToDo comments to highlight the missing functionality. Pending to implement operations should be indicated with todo comments to highlight the missing functionality.
```python ```python
# ToDo: right now extracted at the city level, in the future should be extracted also at building level if exist # todo: right now extracted at the city level, in the future should be extracted also at building level if exist
``` ```

2
city_model_structure/building.py
View File

@ -150,7 +150,7 @@ class Building(CityObject):
""" """
Raises not implemented error Raises not implemented error
""" """
# ToDo: this need to be calculated based on the basement and attic heated values # todo: this need to be calculated based on the basement and attic heated values
raise NotImplementedError raise NotImplementedError
@property @property

2
exports/energy_systems/heat_pump_export.py
View File

@ -176,7 +176,7 @@ class HeatPumpExport:
self._input_data["HPDisactivationTemperature"] = self._input_data["HPSupTemp"] - 2 self._input_data["HPDisactivationTemperature"] = self._input_data["HPSupTemp"] - 2
self._input_data["HPReactivationTemperature"] = self._input_data["HPSupTemp"] - 4 self._input_data["HPReactivationTemperature"] = self._input_data["HPSupTemp"] - 4
# compute maximum demand. TODO: This should come from catalog in the future # compute maximum demand. todo: This should come from catalog in the future
max_demand = self._compute_max_demand() max_demand = self._compute_max_demand()
# compute TESCapacity # compute TESCapacity
self._input_data["TESCapacity"] = self._input_data["HoursOfStorageAtMaxDemand"] * (max_demand * 3.6) / ( self._input_data["TESCapacity"] = self._input_data["HoursOfStorageAtMaxDemand"] * (max_demand * 3.6) / (

4
exports/formats/idf.py
View File

@ -425,7 +425,7 @@ class Idf:
self._add_shading(building) self._add_shading(building)
else: else:
self._add_block(building) self._add_block(building)
# TODO: this should change to specific variables per zone to process only the ones in the buildings_to_calculate # todo: this should change to specific variables per zone to process only the ones in the buildings_to_calculate
for building in self._target_buildings: for building in self._target_buildings:
continue continue
@ -489,7 +489,7 @@ class Idf:
Diffuse_Visible_Reflectance_of_Unglazed_Part_of_Shading_Surface=visible_reflectance, Diffuse_Visible_Reflectance_of_Unglazed_Part_of_Shading_Surface=visible_reflectance,
Fraction_of_Shading_Surface_That_Is_Glazed=0) Fraction_of_Shading_Surface_That_Is_Glazed=0)
# TODO: Add properties for that name # todo: Add properties for that name
def _add_surfaces(self, building, zone_name): def _add_surfaces(self, building, zone_name):
for internal_zone in building.internal_zones: for internal_zone in building.internal_zones:

2
imports/construction/helpers/construction_helper.py
View File

@ -103,7 +103,7 @@ class ConstructionHelper:
:param city: str :param city: str
:return: str :return: str
""" """
# ToDo: Dummy function that needs to be implemented # todo: Dummy function that needs to be implemented
reference_city = 'Baltimore' reference_city = 'Baltimore'
if city is not None: if city is not None:
reference_city = 'Baltimore' reference_city = 'Baltimore'

5
unittests/test_exports.py
View File

@ -103,10 +103,7 @@ class TestExports(TestCase):
UsageFactory('comnet', city).enrich() UsageFactory('comnet', city).enrich()
try: try:
ExportsFactory('idf', city, self._output_path).export() ExportsFactory('idf', city, self._output_path).export()
ExportsFactory('idf', city, self._output_path, target_buildings=['gml_1066158', 'gml_1']).export() ExportsFactory('idf', city, self._output_path, target_buildings=['gml_1066158', 'gml_1066159']).export()
ExportsFactory('idf', city, self._output_path, target_buildings=['gml_1066158'],
adjacent_buildings=['gml_1']).export()
ExportsFactory('idf', city, self._output_path, target_buildings=['gml_1066158']).export()
except Exception: except Exception:
self.fail("Idf ExportsFactory raised ExceptionType unexpectedly!") self.fail("Idf ExportsFactory raised ExceptionType unexpectedly!")