m_osman/city_retrofit
1
0
Fork 0
forked from s_ranjbar/city_retrofit
Code Pull Requests Activity

Bugfix: now surfaces has associated thermal boundaries after construction factory

Browse Source
This commit is contained in:
Guille Gutierrez 2024-06-27 16:22:57 +02:00
parent c36ce1b83a
commit 915170e60f
4 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hub/city_model_structure/building_demand/surface.py
View File

@ -42,7 +42,7 @@ class Surface:
self._short_wave_reflectance = None self._short_wave_reflectance = None
self._long_wave_emittance = None self._long_wave_emittance = None
self._inverse = None self._inverse = None
self._associated_thermal_boundaries = [] self._associated_thermal_boundaries = None
self._vegetation = None self._vegetation = None
self._percentage_shared = None self._percentage_shared = None
self._solar_collectors_area_reduction_factor = None self._solar_collectors_area_reduction_factor = None

2
hub/imports/construction_factory.py
View File

@ -54,3 +54,5 @@ class ConstructionFactory:
:return: None :return: None
""" """
getattr(self, self._handler, lambda: None)() getattr(self, self._handler, lambda: None)()
for building in self._city.buildings:
_ = building.thermal_zones_from_internal_zones # ensure internal zones initialization

2
tests/test_exports.py
View File

@ -144,6 +144,6 @@ class TestExports(TestCase):
UsageFactory('nrcan', city).enrich() UsageFactory('nrcan', city).enrich()
WeatherFactory('epw', city).enrich() WeatherFactory('epw', city).enrich()
try: try:
EnergyBuildingsExportsFactory('idf', city, self._output_path).export() EnergyBuildingsExportsFactory('idf', city, self._output_path, target_buildings=[1]).export()
except Exception: except Exception:
self.fail("Idf ExportsFactory raised ExceptionType unexpectedly!") self.fail("Idf ExportsFactory raised ExceptionType unexpectedly!")

2
tests/test_geometry_factory.py
View File

@ -93,7 +93,7 @@ class TestGeometryFactory(TestCase):
self.assertIsNone(surface.short_wave_reflectance, 'surface short_wave_reflectance is not none') self.assertIsNone(surface.short_wave_reflectance, 'surface short_wave_reflectance is not none')
self.assertIsNone(surface.long_wave_emittance, 'surface long_wave_emittance is not none') self.assertIsNone(surface.long_wave_emittance, 'surface long_wave_emittance is not none')
self.assertIsNotNone(surface.inverse, 'surface inverse is none') self.assertIsNotNone(surface.inverse, 'surface inverse is none')
self.assertEqual(len(surface.associated_thermal_boundaries), 0, 'associated_thermal_boundaries are assigned') self.assertIsNone(surface.associated_thermal_boundaries, 'associated_thermal_boundaries are assigned')
self.assertIsNone(surface.vegetation, 'surface vegetation is not none') self.assertIsNone(surface.vegetation, 'surface vegetation is not none')
# citygml_classes # citygml_classes