s_ranjbar/city_retrofit
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

solved feature in idf generator

Browse Source
This commit is contained in:
Pilar Monsalvete 2023-06-06 16:09:33 -04:00
parent c0a2a8a2f9
commit 4ccf16411c
4 changed files with 46 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hub/city_model_structure/building_demand/thermal_zone.py
View File

@ -617,8 +617,11 @@ class ThermalZone:
_mean_peak_flow = 0
_mean_service_temperature = 0
for usage in self.usages:
if usage.domestic_hot_water.density is not None:
_mean_peak_density_load += usage.percentage * usage.domestic_hot_water.density
if usage.domestic_hot_water.peak_flow is not None:
_mean_peak_flow += usage.percentage * usage.domestic_hot_water.peak_flow
if usage.domestic_hot_water.service_temperature is not None:
_mean_service_temperature += usage.percentage * usage.domestic_hot_water.service_temperature
self._domestic_hot_water.density = _mean_peak_density_load
self._domestic_hot_water.peak_flow = _mean_peak_flow

34
hub/exports/building_energy/idf.py
View File

@ -83,6 +83,7 @@ class Idf:
def __init__(self, city, output_path, idf_file_path, idd_file_path, epw_file_path, export_type="Surfaces",
target_buildings=None):
self._city = city
self._sanity_check()
self._output_path = str(output_path.resolve())
self._output_file = str((output_path / f'{city.name}.idf').resolve())
self._export_type = export_type
@ -106,6 +107,25 @@ class Idf:
self._adjacent_buildings += building.neighbours
self._export()
def _sanity_check(self):
levels_of_detail = self._city.level_of_detail
if levels_of_detail.geometry is None:
raise AttributeError('Level of detail of geometry not assigned')
if levels_of_detail.geometry < 1:
raise AttributeError(f'Level of detail of geometry = {levels_of_detail.geometry}. Required minimum level 1')
if levels_of_detail.construction is None:
raise AttributeError('Level of detail of construction not assigned')
if levels_of_detail.construction < 2:
raise AttributeError(f'Level of detail of construction = {levels_of_detail.construction}. Required minimum level 2')
if levels_of_detail.usage is None:
raise AttributeError('Level of detail of usage not assigned')
if levels_of_detail.usage < 2:
raise AttributeError(f'Level of detail of usage = {levels_of_detail.usage}. Required minimum level 2')
if levels_of_detail.weather is None:
raise AttributeError('Level of detail of weather not assigned')
if levels_of_detail.weather < 2:
raise AttributeError(f'Level of detail of weather = {levels_of_detail.weather}. Required minimum level 2')
@staticmethod
def _matrix_to_list(points, lower_corner):
lower_x = lower_corner[0]
@ -294,9 +314,9 @@ class Idf:
return
def _add_construction(self, thermal_boundary):
vegetation_name = f'{thermal_boundary.construction_name}_{thermal_boundary.parent_surface.vegetation.name}'
for construction in self._idf.idfobjects[self._CONSTRUCTION]:
if thermal_boundary.parent_surface.vegetation is not None:
vegetation_name = f'{thermal_boundary.construction_name}_{thermal_boundary.parent_surface.vegetation.name}'
if construction.Name == vegetation_name:
return
else:
@ -313,6 +333,7 @@ class Idf:
layers = thermal_boundary.layers
# The constructions should have at least one layer
if thermal_boundary.parent_surface.vegetation is not None:
vegetation_name = f'{thermal_boundary.construction_name}_{thermal_boundary.parent_surface.vegetation.name}'
_kwargs = {'Name': vegetation_name,
'Outside_Layer': thermal_boundary.parent_surface.vegetation.name}
for i in range(0, len(layers) - 1):
@ -430,8 +451,10 @@ class Idf:
if zone.Name == f'{zone_name}_infiltration':
return
schedule = f'Infiltration schedules {thermal_zone.usage_name}'
if schedule not in self._idf.idfobjects[self._HOURLY_SCHEDULE]:
return
# todo: if the schedule doesn't exist, does the idf notices??
# We shouldn't check this because the schedules could be written later
# if schedule not in self._idf.idfobjects[self._COMPACT_SCHEDULE]:
# return
self._idf.newidfobject(self._INFILTRATION,
Name=f'{zone_name}_infiltration',
Zone_or_ZoneList_Name=zone_name,
@ -445,9 +468,10 @@ class Idf:
if zone.Name == f'{zone_name}_ventilation':
return
schedule = f'Ventilation schedules {thermal_zone.usage_name}'
#if schedule not in self._idf.idfobjects[self._HOURLY_SCHEDULE]:
# todo: if the schedule doesn't exist, does the idf notices??
# We shouldn't check this because the schedules could be written later
# if schedule not in self._idf.idfobjects[self._COMPACT_SCHEDULE]:
# return
# todo: revise ventilation with Pilar
self._idf.newidfobject(self._VENTILATION,
Name=f'{zone_name}_ventilation',
Zone_or_ZoneList_Name=zone_name,

2
hub/exports/building_energy/insel/insel_monthly_energy_balance.py
View File

@ -76,7 +76,7 @@ class InselMonthlyEnergyBalance:
if levels_of_detail.geometry is None:
raise AttributeError('Level of detail of geometry not assigned')
if levels_of_detail.geometry < 1:
raise AttributeError(f'Level of detail of geometry = {levels_of_detail.geometry}. Required minimum level 0.5')
raise AttributeError(f'Level of detail of geometry = {levels_of_detail.geometry}. Required minimum level 1')
if levels_of_detail.construction is None:
raise AttributeError('Level of detail of construction not assigned')
if levels_of_detail.construction < 1: