From 20a801626a1f7c1adeb0f8db53d6d44d315b7ba9 Mon Sep 17 00:00:00 2001 From: s_ranjbar Date: Mon, 9 Sep 2024 11:18:00 -0400 Subject: [PATCH] fix: small bug in irradiance units impacting MEB results was fixed --- hub/city_model_structure/building_demand/surface.py | 8 ++++---- hub/imports/results/simplified_radiosity_algorithm.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hub/city_model_structure/building_demand/surface.py b/hub/city_model_structure/building_demand/surface.py index f054e577..79c835dd 100644 --- a/hub/city_model_structure/building_demand/surface.py +++ b/hub/city_model_structure/building_demand/surface.py @@ -180,7 +180,7 @@ class Surface: @property def global_irradiance(self) -> dict: """ - Get global irradiance on surface in J/m2 + Get global irradiance on surface in W/m2 :return: dict """ return self._global_irradiance @@ -188,7 +188,7 @@ class Surface: @global_irradiance.setter def global_irradiance(self, value): """ - Set global irradiance on surface in J/m2 + Set global irradiance on surface in W/m2 :param value: dict """ self._global_irradiance = value @@ -390,7 +390,7 @@ class Surface: @property def global_irradiance_tilted(self) -> dict: """ - Get global irradiance on a tilted surface in J/m2 + Get global irradiance on a tilted surface in W/m2 :return: dict """ return self._global_irradiance_tilted @@ -398,7 +398,7 @@ class Surface: @global_irradiance_tilted.setter def global_irradiance_tilted(self, value): """ - Set global irradiance on a tilted surface in J/m2 + Set global irradiance on a tilted surface in W/m2 :param value: dict """ self._global_irradiance_tilted = value diff --git a/hub/imports/results/simplified_radiosity_algorithm.py b/hub/imports/results/simplified_radiosity_algorithm.py index 3824e7ce..9b09b5f8 100644 --- a/hub/imports/results/simplified_radiosity_algorithm.py +++ b/hub/imports/results/simplified_radiosity_algorithm.py @@ -34,7 +34,7 @@ class SimplifiedRadiosityAlgorithm: for key in self._results: _irradiance = {} header_name = key.split(':') - result = [x * cte.WATTS_HOUR_TO_JULES for x in self._results[key]] + result = [x for x in self._results[key]] city_object_name = header_name[1] building = self._city.city_object(city_object_name) surface_id = header_name[2]