From 634bbc286ff8c6257fe7243d9d1f9535009e9a04 Mon Sep 17 00:00:00 2001 From: guille Date: Wed, 7 Apr 2021 11:52:39 -0400 Subject: [PATCH] Change export method from property to function to improve the semantic --- exports/exports_factory.py | 3 +-- tests/test_exports.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/exports/exports_factory.py b/exports/exports_factory.py index c7a1a0e0..8924e6eb 100644 --- a/exports/exports_factory.py +++ b/exports/exports_factory.py @@ -58,11 +58,10 @@ class ExportsFactory: """ raise NotImplementedError() - @property def export(self): """ Export the city model structure to the given export type - :return: City + :return: None """ return getattr(self, self._export_type, lambda: None) diff --git a/tests/test_exports.py b/tests/test_exports.py index 3e925dc2..96cf12d8 100644 --- a/tests/test_exports.py +++ b/tests/test_exports.py @@ -44,7 +44,7 @@ class TestExports(TestCase): def _export(self, export_type): self._city_gml = self._get_city() - ExportsFactory(export_type, self._city_gml, self._output_path).export + ExportsFactory(export_type, self._city_gml, self._output_path).export() def test_obj_export(self): self._export('obj')