From fc61c5db5f627b42c3b913762e9b64bc1e50e4cc Mon Sep 17 00:00:00 2001
From: jgavalda <oriol.gavalda@concordia.ca>
Date: Tue, 23 May 2023 14:49:29 -0400
Subject: [PATCH] Changes in structure of xml to include systems and subsystems

---
 .../montreal_custom_systems.xml               | 287 ++++++++++++------
 1 file changed, 194 insertions(+), 93 deletions(-)

diff --git a/hub/data/energy_systems/montreal_custom_systems.xml b/hub/data/energy_systems/montreal_custom_systems.xml
index 97813ec6..b49bbc62 100644
--- a/hub/data/energy_systems/montreal_custom_systems.xml
+++ b/hub/data/energy_systems/montreal_custom_systems.xml
@@ -26,34 +26,72 @@
         </equipment>
     </generation_equipments>
     <distribution_equipments>
-        <equipment id="1" type="??">
-            <name>???</name>
+        <equipment id="1" type="Water distribution heating">
+            <name>Water distribution heating</name>
             <distribution_heat_losses units="%">10</distribution_heat_losses>
-            <distribution_consumption_fix_flow units="%">1000000000</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">1000000000</distribution_consumption_variable_flow>
+            <distribution_consumption_fix_flow units="%">4</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">1</distribution_consumption_variable_flow>
         </equipment>
-        <equipment id="2" type="??">
-            <name>???</name>
-            <distribution_heat_losses units="%">25</distribution_heat_losses>
-            <distribution_consumption_fix_flow units="%">1000000000</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">1000000000</distribution_consumption_variable_flow>
+        <equipment id="2" type="Water distribution cooling">
+            <name>Water distribution cooling</name>
+            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_consumption_fix_flow units="%">4</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">1</distribution_consumption_variable_flow>
         </equipment>
-        <equipment id="3" type="??">
-            <name>???</name>
+        <equipment id="3" type="Central air distribution heating">
+            <name>Central air distribution heating</name>
+            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_consumption_fix_flow units="%">13</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">13</distribution_consumption_variable_flow>
+        </equipment>
+        <equipment id="4" type="Central air distribution cooling">
+            <name>Central air distribution cooling</name>
+            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_consumption_fix_flow units="%">13</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">13</distribution_consumption_variable_flow>
+        </equipment>
+        <equipment id="5" type="Local air distribution heating">
+            <name>Local air distribution heating</name>
+            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_consumption_fix_flow units="%">8</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">8</distribution_consumption_variable_flow>
+        </equipment>
+         <equipment id="6" type="Local air distribution cooling">
+            <name>Local air distribution cooling</name>
+            <distribution_heat_losses units="%">10</distribution_heat_losses>
+            <distribution_consumption_fix_flow units="%">8</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">8</distribution_consumption_variable_flow>
+        </equipment>
+        <equipment id="7" type="Refrigerant distribution">
+            <name>Refrigerant distribution</name>
+            <distribution_heat_losses units="%">1</distribution_heat_losses>
+            <distribution_consumption_fix_flow units="%">1</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">2</distribution_consumption_variable_flow>
+        </equipment>
+        <equipment id="8" type="No distribution">
+            <name>No distribution</name>
             <distribution_heat_losses units="%">0</distribution_heat_losses>
-            <distribution_consumption_fix_flow units="%">1000000000</distribution_consumption_fix_flow>
-            <distribution_consumption_variable_flow units="%">1000000000</distribution_consumption_variable_flow>
+            <distribution_consumption_fix_flow units="%">0</distribution_consumption_fix_flow>
+            <distribution_consumption_variable_flow units="%">0</distribution_consumption_variable_flow>
         </equipment>
     </distribution_equipments>
     <dissipation_equipments>
         <equipment id="1" type="baseboards">
             <name>Baseboards</name>
-            <parasitic_consumption>???</parasitic_consumption>
+            <parasitic_consumption>0</parasitic_consumption>
+        </equipment>
+        <equipment id="2" type="fan-coils">
+            <name>fan-coils</name>
+            <parasitic_consumption>2</parasitic_consumption>
+        </equipment>
+        <equipment id="3" type="inductors">
+            <name>inductors</name>
+            <parasitic_consumption>0</parasitic_consumption>
         </equipment>
     </dissipation_equipments>
     <systems>
         <system id = "1">
-            <name>Fuel-fired water boiler with baseboards</name>
+            <name>Unitary air conditioner with baseboard heater fuel fired boiler</name>
             <demands>
                 <demand>heating</demand>
                 <demand>domestic_hot_water</demand>
@@ -61,12 +99,25 @@
             <equipments>
                 <generation_id>1</generation_id>
                 <distribution_id>1</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <dissipation_id>1</dissipation_id>
             </equipments>
             <storage>false</storage>
         </system>
-        <system id="2">
-            <name>Electrical resistance water boiler</name>
+        <system id = "2">
+            <name>4 pipe fan coils with fuel fired boiler</name>
+            <demands>
+                <demand>heating</demand>
+                <demand>domestic_hot_water</demand>
+            </demands>
+            <equipments>
+                <generation_id>1</generation_id>
+                <distribution_id>1</distribution_id>
+                <dissipation_id>2</dissipation_id>
+            </equipments>
+            <storage>false</storage>
+        </system>
+        <system id="3">
+            <name>4 pipe fan coils with electrical resistance water boiler</name>
             <demands>
                 <demand>heating</demand>
                 <demand>domestic_hot_water</demand>
@@ -74,38 +125,38 @@
             <equipments>
                 <generation_id>2</generation_id>
                 <distribution_id>1</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <dissipation_id>2</dissipation_id>
             </equipments>
             <storage>true</storage>
         </system>
-        <system id="3">
-            <name>Fuel-fired furnace and fuel boiler for acs</name>
+        <system id="4">
+            <name>Single zone packaged rooftop unit with fuel-fired furnace and baseboards and fuel boiler for acs</name>
             <demands>
                 <demand>heating</demand>
-                 <demand>domestic_hot_water</demand>
+                <demand>domestic_hot_water</demand>
            </demands>
             <equipments>
                 <generation_id>3</generation_id>
-                <distribution_id>2</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <distribution_id>5</distribution_id>
+                <dissipation_id>1</dissipation_id>
             </equipments>
             <storage>false</storage>
         </system>
-        <system id="4">
-            <name>Electrical resistance furnace and electrical boiler for acs</name>
+        <system id="5">
+            <name>Single zone packaged rooftop unit with electrical resistance furnace and baseboards and fuel boiler for acs</name>
             <demands>
                 <demand>heating</demand>
                 <demand>domestic_hot_water</demand>
             </demands>
             <equipments>
                 <generation_id>4</generation_id>
-                <distribution_id>2</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <distribution_id>5</distribution_id>
+                <dissipation_id>1</dissipation_id>
             </equipments>
             <storage>false</storage>
         </system>
-        <system id="5">
-            <name>Baseboards: hydronic with fuel boiler</name>
+        <system id="6">
+            <name>Single zone make-up air unit with baseboard heating with fuel fired boiler</name>
             <demands>
                 <demand>heating</demand>
                 <demand>domestic_hot_water</demand>
@@ -113,68 +164,118 @@
             <equipments>
                 <generation_id>1</generation_id>
                 <distribution_id>1</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <dissipation_id>1</dissipation_id>
             </equipments>
             <storage>false</storage>
         </system>
-        <system id="6">
-            <name>Electrical baseboards and electrical boiler for acs</name>
+        <system id="7">
+            <name>Single zone make-up air unit with electrical baseboard heating and DHW with resistance</name>
             <demands>
                 <demand>heating</demand>
                 <demand>domestic_hot_water</demand>
             </demands>
             <equipments>
                 <generation_id>2</generation_id>
-                <distribution_id>3</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <distribution_id>5</distribution_id>
+                <dissipation_id>3</dissipation_id>
             </equipments>
             <storage>false</storage>
         </system>
-        <system id="7">
-            <name>Air cooled DX with external condenser</name>
+         <system id="8">
+            <name>Multi-zone built-up system with baseboard heater hydronic with fuel fired boiler</name>
             <demands>
-                <demand>cooling</demand>
+                <demand>heating</demand>
+                <demand>domestic_hot_water</demand>
             </demands>
             <equipments>
-                <generation_id>5</generation_id>
-                <distribution_id>3</distribution_id>
-                <dissipation_id>???</dissipation_id>
-            </equipments>
-            <storage>false</storage>
-        </system>
-        <system id="8">
-            <name>Water cooled, water chiller</name>
-            <demands>
-                <demand>cooling</demand>
-            </demands>
-            <equipments>
-                <generation_id>5</generation_id>
+                <generation_id>2</generation_id>
                 <distribution_id>1</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <dissipation_id>3</dissipation_id>
             </equipments>
             <storage>false</storage>
         </system>
-        <system id="9">
-            <name>Air cooled DX</name>
+         <system id="9">
+            <name>Multi-zone built-up system with electrical baseboard heater and electrical hot water</name>
             <demands>
-                <demand>cooling</demand>
+                <demand>heating</demand>
+                <demand>domestic_hot_water</demand>
             </demands>
             <equipments>
-                <generation_id>5</generation_id>
-                <distribution_id>3</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <generation_id>2</generation_id>
+                <distribution_id>1</distribution_id>
+                <dissipation_id>3</dissipation_id>
             </equipments>
             <storage>false</storage>
         </system>
         <system id="10">
+            <name>Unitary air conditioner air cooled DX with external condenser</name>
+            <demands>
+                <demand>cooling</demand>
+            </demands>
+            <equipments>
+                <generation_id>5</generation_id>
+                <distribution_id>6</distribution_id>
+                <dissipation_id>3</dissipation_id>
+            </equipments>
+            <storage>false</storage>
+        </system>
+        <system id="11">
+            <name>4 pipe fan coils with water cooled, water chiller</name>
+            <demands>
+                <demand>cooling</demand>
+            </demands>
+            <equipments>
+                <generation_id>5</generation_id>
+                <distribution_id>2</distribution_id>
+                <dissipation_id>2</dissipation_id>
+            </equipments>
+            <storage>false</storage>
+        </system>
+        <system id="12">
+            <name>Single zone packaged rooftop unit with air cooled DX</name>
+            <demands>
+                <demand>cooling</demand>
+            </demands>
+            <equipments>
+                <generation_id>5</generation_id>
+                <distribution_id>6</distribution_id>
+                <dissipation_id>3</dissipation_id>
+            </equipments>
+            <storage>false</storage>
+        </system>
+        <system id="13">
+            <name>Single zone make-up air unit with air cooled DX</name>
+            <demands>
+                <demand>cooling</demand>
+            </demands>
+            <equipments>
+                <generation_id>5</generation_id>
+                <distribution_id>6</distribution_id>
+                <dissipation_id>3</dissipation_id>
+            </equipments>
+            <storage>false</storage>
+        </system>
+        <system id="14">
+            <name>Multi-zone built-up system with water cooled, water chiller</name>
+            <demands>
+                <demand>cooling</demand>
+            </demands>
+            <equipments>
+                <generation_id>5</generation_id>
+                <distribution_id>3</distribution_id>
+                <dissipation_id>3</dissipation_id>
+            </equipments>
+            <storage>false</storage>
+        </system>
+        <system id="15">
             <name>PV system</name>
             <demands>
                 <demand>electricity</demand>
             </demands>
             <equipments>
                 <generation_id>6</generation_id>
-                <distribution_id>???</distribution_id>
-                <dissipation_id>???</dissipation_id>
+                <distribution_id>5</distribution_id>
+                <dissipation_id>3</dissipation_id>
             </equipments>
             <storage>true</storage>
         </system>
@@ -190,109 +291,109 @@
             <systems>
                 <system_id>1</system_id>
                 <system_id>7</system_id>
-                <system_id>10</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 1 electricity">
             <systems>
-                <system_id>2</system_id>
-                <system_id>7</system_id>
+                <system_id>1</system_id>
+                <system_id>10</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 1 electricity pv">
             <systems>
                 <system_id>2</system_id>
-                <system_id>7</system_id>
                 <system_id>10</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 2 gas">
             <systems>
-                <system_id>1</system_id>
-                <system_id>8</system_id>
+                <system_id>2</system_id>
+                <system_id>11</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 2 gas pv">
             <systems>
-                <system_id>1</system_id>
-                <system_id>8</system_id>
-                <system_id>10</system_id>
+                <system_id>2</system_id>
+                <system_id>11</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 2 electricity">
             <systems>
-                <system_id>2</system_id>
-                <system_id>8</system_id>
+                <system_id>3</system_id>
+                <system_id>11</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 2 electricity pv">
             <systems>
-                <system_id>2</system_id>
-                <system_id>8</system_id>
-                <system_id>10</system_id>
+                <system_id>3</system_id>
+                <system_id>11</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 3 and 4 gas">
             <systems>
-                <system_id>3</system_id>
                 <system_id>4</system_id>
+                <system_id>12</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 3 and 4 gas pv">
             <systems>
-                <system_id>3</system_id>
                 <system_id>4</system_id>
-                <system_id>10</system_id>
+                <system_id>12</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 3 and 4 electricity">
             <systems>
-                <system_id>4</system_id>
-                <system_id>4</system_id>
+                <system_id>5</system_id>
+                <system_id>12</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 3 and 4 electricity pv">
             <systems>
-                <system_id>4</system_id>
-                <system_id>4</system_id>
-                <system_id>10</system_id>
+                <system_id>5</system_id>
+                <system_id>12</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 5">
             <systems>
-                <system_id>8</system_id>
+                <system_id>11</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 5 pv">
             <systems>
-                <system_id>8</system_id>
-                <system_id>10</system_id>
+                <system_id>11</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 6 gas">
             <systems>
-                <system_id>5</system_id>
                 <system_id>8</system_id>
+                <system_id>14</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 6 gas pv">
             <systems>
-                <system_id>5</system_id>
                 <system_id>8</system_id>
-                <system_id>10</system_id>
+                <system_id>14</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 6 electricity">
             <systems>
-                <system_id>6</system_id>
-                <system_id>8</system_id>
+                <system_id>9</system_id>
+                <system_id>14</system_id>
             </systems>
         </system_cluster>
         <system_cluster name="system 6 electricity pv">
             <systems>
-                <system_id>6</system_id>
-                <system_id>8</system_id>
-                <system_id>10</system_id>
+                <system_id>9</system_id>
+                <system_id>14</system_id>
+                <system_id>15</system_id>
             </systems>
         </system_cluster>
     </system_clusters>