s_ranjbar/summer_course_2024
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'added surface type to construction names' (#36) from bug_in_construction_importers into main

Browse Source 
Reviewed-on: https://nextgenerations-cities.encs.concordia.ca/gitea/CERC/hub/pulls/36
This commit is contained in:
Guille Gutierrez 2023-07-25 12:03:42 -04:00
commit e82d20bfd7
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hub/imports/construction/eilat_physics_parameters.py
View File

@ -97,7 +97,7 @@ class EilatPhysicsParameters:
thermal_zone.infiltration_rate_system_off = archetype.infiltration_rate_for_ventilation_system_off thermal_zone.infiltration_rate_system_off = archetype.infiltration_rate_for_ventilation_system_off
for thermal_boundary in thermal_zone.thermal_boundaries: for thermal_boundary in thermal_zone.thermal_boundaries:
construction_archetype = self._search_construction_in_archetype(archetype, thermal_boundary.type) construction_archetype = self._search_construction_in_archetype(archetype, thermal_boundary.type)
thermal_boundary.construction_name = construction_archetype.name thermal_boundary.construction_name = f'{thermal_boundary.type}_{construction_archetype.name}'
try: try:
thermal_boundary.window_ratio = 0 thermal_boundary.window_ratio = 0
if thermal_boundary.type in (cte.WALL, cte.ROOF): if thermal_boundary.type in (cte.WALL, cte.ROOF):

2
hub/imports/construction/nrcan_physics_parameters.py
View File

@ -97,7 +97,7 @@ class NrcanPhysicsParameters:
thermal_zone.infiltration_rate_system_off = archetype.infiltration_rate_for_ventilation_system_off thermal_zone.infiltration_rate_system_off = archetype.infiltration_rate_for_ventilation_system_off
for thermal_boundary in thermal_zone.thermal_boundaries: for thermal_boundary in thermal_zone.thermal_boundaries:
construction_archetype = self._search_construction_in_archetype(archetype, thermal_boundary.type) construction_archetype = self._search_construction_in_archetype(archetype, thermal_boundary.type)
thermal_boundary.construction_name = construction_archetype.name thermal_boundary.construction_name = f'{thermal_boundary.type}_{construction_archetype.name}'
try: try:
thermal_boundary.window_ratio = 0 thermal_boundary.window_ratio = 0
if thermal_boundary.type in ( cte.WALL, cte.ROOF): if thermal_boundary.type in ( cte.WALL, cte.ROOF):