Koa Wells k_wells
  • Joined on 2022-12-06
k_wells approved CERC/mtl_gis_oo#1 2024-11-19 12:25:53 -05:00
Add readme
k_wells commented on pull request CERC/mtl_gis_oo#1 2024-11-19 12:25:47 -05:00
Add readme

Hi Ali, I am accepting this PR with the changes you have made so far. Please go ahead and merge the branch, then delete the branch. Thanks !

k_wells opened issue CERC/hub#74 2024-11-05 13:05:13 -05:00
Feature Request: Add input building usage to buildings class
k_wells suggested changes for CERC/mtl_gis_oo#1 2024-10-31 15:07:32 -04:00
Add readme

Hi Ali, here is my first round of feedback. Please take a look at these when you can then I will do a final review to make sure there is nothing that I missed.

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 15:06:38 -04:00
Add readme

It's bad practice to import * so I would remove this line. Generally you only want to import what you need and nothing more.

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 14:16:29 -04:00
Add readme

this is not needed as the following line will allow for all files inside of C:\Program Files\QGIS 3.34.1\apps\Python39 to be accessible in Command Prompt or Powershell

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 14:15:19 -04:00
Add readme

Is there a reason you make a copy instead of just renaming the executable? If this is added to the path variable, your command prompt might point to this version of python 3.9 instead of the user/system installation of python 3.9 if it exists.

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 14:13:45 -04:00
Add readme

Remove this line

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 14:13:01 -04:00
Add readme

rename from handle_mtl_ds_workflow.py to montreal_buildings_workflow.py, quebec_buildings_workflow.py, or building_cleanup_workflow.py depending on what you feel fits the best. Call the section Montreal Building Workflow corresponding to the name of the file

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 14:10:12 -04:00
Add readme

Rename scrub_layer_class.py to scrub_layer.py and call this section ScrubLayer following the class name

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 14:06:53 -04:00
Add readme
  • Remove reference to stsandalone_vs.py as this is coming from the previous project.
k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 13:43:36 -04:00
Add readme

This file does not exist in this project so this section should be removed

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 13:24:50 -04:00
Add readme

The original workflow was developed in ArcGIS

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 13:23:51 -04:00
Add readme

I would remove the 'non-object-oriented project' and just say that it is a continuation of the project and provide the link

k_wells commented on pull request CERC/mtl_gis_oo#1 2024-10-31 13:08:32 -04:00
Add readme

Remove the word 'updated' and 'object-oriented approach'

k_wells transferred repository a_adli/mtl_gis_oo to CERC/mtl_gis_oo 2024-10-30 18:37:59 -04:00
k_wells deleted branch fix/fix-build from CERC/hub 2024-10-03 14:08:41 -04:00
k_wells pushed to main at CERC/hub 2024-10-03 14:08:40 -04:00
5e01f4eb7f Merge pull request 'Remove build from setup.py and add it to requirements.txt' (#69) from fix/fix-build into main
d38150ac2d Remove build from setup.py and add it to requirements.txt
Compare 2 commits »
k_wells merged pull request CERC/hub#69 2024-10-03 14:08:38 -04:00
Remove build from setup.py and add it to requirements.txt
k_wells created pull request CERC/hub#69 2024-10-03 14:08:31 -04:00
Remove build from setup.py and add it to requirements.txt